lkml.org 
[lkml]   [2014]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 10/14] HID: wiimote: replace hid_output_raw_report with hid_hw_output_report for output requests
From
Hi

On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> For BT transport layer,
> ret = hid_output_raw_report(A, B, C, HID_OUTPUT_REPORT);
> is equivalent to
> ret = hid_hw_output_report(A, B, C);
>
> So use the new API where available

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> drivers/hid/hid-wiimote-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c
> index d7dc6c5b..d003914 100644
> --- a/drivers/hid/hid-wiimote-core.c
> +++ b/drivers/hid/hid-wiimote-core.c
> @@ -28,14 +28,14 @@ static int wiimote_hid_send(struct hid_device *hdev, __u8 *buffer,
> __u8 *buf;
> int ret;
>
> - if (!hdev->hid_output_raw_report)
> + if (!hdev->ll_driver->output_report)
> return -ENODEV;
>
> buf = kmemdup(buffer, count, GFP_KERNEL);
> if (!buf)
> return -ENOMEM;
>
> - ret = hid_output_raw_report(hdev, buf, count, HID_OUTPUT_REPORT);
> + ret = hid_hw_output_report(hdev, buf, count);
>
> kfree(buf);
> return ret;
> --
> 1.8.3.1
>


\
 
 \ /
  Last update: 2014-02-12 16:01    [W:0.276 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site