lkml.org 
[lkml]   [2014]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/14] mfd/rtc: sec/sec: Rename SEC* symbols to S5M
    > This patch prepares for adding support for S2MPS14 RTC device to the
    > rtc-s5m driver:
    > 1. Renames SEC* symbols to S5M.
    > 2. Adds S5M prefix to some of defines which are different between S5M876X
    > and S2MPS14.
    >
    > This is only a rename-like patch, new code is not added.
    >
    > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    > Cc: Alessandro Zummo <a.zummo@towertech.it>
    > Cc: rtc-linux@googlegroups.com
    > ---
    > drivers/mfd/sec-core.c | 2 +-
    > drivers/rtc/rtc-s5m.c | 64 ++++++++++++++++-----------------
    > include/linux/mfd/samsung/rtc.h | 76 +++++++++++++++++++--------------------
    > 3 files changed, 71 insertions(+), 71 deletions(-)

    Hmmm...

    > - .max_register = SEC_RTC_REG_MAX,
    > + .max_register = S5M_RTC_REG_MAX,
    > };

    <snip>

    > - SEC_RTC_REG_MAX,
    > + S5M_RTC_REG_MAX,
    > };

    You only just introduced these 2 patches ago!

    It's not a big enough of a deal for a NACK though I guess.

    On the basis that this set is going to go in as one big set:
    Acked-by: Lee Jones <lee.jones@linaro.org>

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-02-12 11:01    [W:2.293 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site