lkml.org 
[lkml]   [2014]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 083/120] drm/radeon: set si_notify_smc_display_change properly
    Date
    3.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alex Deucher <alexander.deucher@amd.com>

    commit ffcda352b569dcf5be5c8a5f57545794acf4adb9 upstream.

    This is effectively a revert of 4573388c92ee60b4ed72b8d95b73df861189988c.

    Forcing a display active when there is none causes problems with
    dpm on some SI boards which results in improperly initialized
    dpm state and boot failures on some boards. As for the bug commit
    4573388c92ee tried to address, one can manually force the state to
    high for better performance when using the card as a headless compute
    node until a better fix is developed.

    bugs:
    https://bugs.freedesktop.org/show_bug.cgi?id=73788
    https://bugs.freedesktop.org/show_bug.cgi?id=69395

    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/radeon/si_dpm.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    --- a/drivers/gpu/drm/radeon/si_dpm.c
    +++ b/drivers/gpu/drm/radeon/si_dpm.c
    @@ -3591,10 +3591,9 @@ static void si_program_display_gap(struc

    /* Setting this to false forces the performance state to low if the crtcs are disabled.
    * This can be a problem on PowerXpress systems or if you want to use the card
    - * for offscreen rendering or compute if there are no crtcs enabled. Set it to
    - * true for now so that performance scales even if the displays are off.
    + * for offscreen rendering or compute if there are no crtcs enabled.
    */
    - si_notify_smc_display_change(rdev, true /*rdev->pm.dpm.new_active_crtc_count > 0*/);
    + si_notify_smc_display_change(rdev, rdev->pm.dpm.new_active_crtc_count > 0);
    }

    static void si_enable_spread_spectrum(struct radeon_device *rdev, bool enable)



    \
     
     \ /
      Last update: 2014-02-12 15:41    [W:4.093 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site