Messages in this thread | | | Date | Tue, 11 Feb 2014 11:39:40 +0000 | Subject | Re: [PATCH v2] mfd: MAX6650/6651 support | From | Laszlo Papp <> |
| |
On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > On 11 February 2014 15:40, Laszlo Papp <lpapp@kde.org> wrote: >>>>> [snip] >>>>>> + >>>>>> +struct max665x_dev { >>>>>> + struct device *dev; >>>>>> + struct mutex iolock; >>>>>> + >>>>>> + struct i2c_client *i2c; >>>>>> + struct regmap *map; >>>>>> + >>>>>> + int type; >>>>> >>>>> Unnecessary extra lines above could be removed. >>>> >>>> I prefer it that way, but I will remove the two extra lines as you wish. >>> >>> As I already said, these are just nits and only since you were >>> re-spinning the patch, >>> I suggested them. Also, since this is a new file being added, it >>> avoids further patches >>> doing these same things. >> >> Well, it is worse in my opinion because it makes the code more bloated >> without separation between units, but I made the requested change >> anyway because the feature matters lotta more to me than this styling. >> Hope it is OK now? > > The only thing that you missed among what you agreed to change is the > arrangement of > "depends on" and "select" in Kconfig. Rest look OK. Thanks for taking care.
Ah, true. I will do that tomorrow if it is a blocker for the integration.
| |