Messages in this thread | | | Date | Tue, 11 Feb 2014 09:58:58 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: sec-core: Fix possible NULL pointer dereference when i2c_new_dummy error |
| |
> During probe the sec-core driver allocates dummy I2C device for RTC with > i2c_new_dummy() but return value is not checked. In case of error > (i2c_new_device(): memory allocation failure or I2C address cannot be > used) this function returns NULL which is later used by > devm_regmap_init_i2c() or i2c_unregister_device(). > > If i2c_new_dummy() fails for RTC device, fail also the probe for main > MFD driver. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: stable@vger.kernel.org > --- > drivers/mfd/sec-core.c | 4 ++++ > 1 file changed, 4 insertions(+)
Applied, thanks.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |