lkml.org 
[lkml]   [2014]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 057/124] b43legacy: Fix unload oops if firmware is not available
    Date
    3.8.13.18 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Larry Finger <Larry.Finger@lwfinger.net>

    commit 452028665312672c6ba9e16a19248ee00ead9400 upstream.

    The asyncronous firmware load uses a completion struct to hold firmware
    processing until the user-space routines are up and running. There is.
    however, a problem in that the waiter is nevered canceled during teardown.
    As a result, unloading the driver when firmware is not available causes an oops.

    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/net/wireless/b43legacy/main.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wireless/b43legacy/main.c
    index 8c3f70e..ded7f6c 100644
    --- a/drivers/net/wireless/b43legacy/main.c
    +++ b/drivers/net/wireless/b43legacy/main.c
    @@ -3918,6 +3918,7 @@ static void b43legacy_remove(struct ssb_device *dev)
    * as the ieee80211 unreg will destroy the workqueue. */
    cancel_work_sync(&wldev->restart_work);
    cancel_work_sync(&wl->firmware_load);
    + complete(&wldev->fw_load_complete);

    B43legacy_WARN_ON(!wl);
    if (!wldev->fw.ucode)
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2014-02-10 22:41    [W:2.196 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site