lkml.org 
[lkml]   [2014]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.8 007/124] rtlwifi: rtl8192cu: Fix duplicate if test
    Date
    3.8.13.18 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Larry Finger <Larry.Finger@lwfinger.net>

    commit 10d0b9030a3f86e1e26c710c7580524d7787d688 upstream.

    A typo causes routine rtl92cu_phy_rf6052_set_cck_txpower() to test the
    same condition twice. The problem was found using cppcheck-1.49, and the
    proper fix was verified against the pre-mac80211 version of the code.

    This patch was originally included as commit 1288aa4, but was accidentally
    reverted in a later patch.

    Reported-by: David Binderman <dcb314@hotmail.com> [original report]
    Reported-by: Andrea Morello <andrea.merello@gmail.com> [report of accidental reversion]
    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/net/wireless/rtlwifi/rtl8192cu/rf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
    index 953f1a0..2119313 100644
    --- a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
    +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
    @@ -104,7 +104,7 @@ void rtl92cu_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
    tx_agc[RF90_PATH_A] = 0x10101010;
    tx_agc[RF90_PATH_B] = 0x10101010;
    } else if (rtlpriv->dm.dynamic_txhighpower_lvl ==
    - TXHIGHPWRLEVEL_LEVEL1) {
    + TXHIGHPWRLEVEL_LEVEL2) {
    tx_agc[RF90_PATH_A] = 0x00000000;
    tx_agc[RF90_PATH_B] = 0x00000000;
    } else{
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2014-02-10 21:21    [W:4.232 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site