Messages in this thread | | | Date | Tue, 09 Dec 2014 15:13:16 -0800 | From | John Fastabend <> | Subject | Re: [PATCH] fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c |
| |
On 12/09/2014 01:42 PM, Eric Dumazet wrote: > On Tue, 2014-12-09 at 16:15 -0500, Valdis Kletnieks wrote: >> commit 46e5da40ae (net: qdisc: use rcu prefix and silence >> sparse warnings) triggers a spurious warning: >> >> net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! >> >> The code should be using the _bh variant of rcu_dereference. >> >> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> >> --- >> net/sched/sch_fq_codel.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Eric Dumazet <edumazet@google.com> > > Thanks ! > >
Great thanks for finding/fixing!
Acked-by: John Fastabend <john.r.fastabend@intel.com>
| |