lkml.org 
[lkml]   [2014]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 2/5] Documentation: bindings: add doc for the Rockchip usb PHY
From
Hi,

2014-12-09 3:48 GMT+01:00 Yunzhi Li <lyz@rock-chips.com>:
> Document the bindings of the Rockchip usb PHY driver.


Long description is the same than the short one.. So either the long
description is useless
or it can be improved.

>
> +Required properties:
> + - compatible: rockchip,rk3288-usb-phy
> + - rockchip,grf : phandle to the syscon managing the "general
> + register files"
> + - #phy-cells: should be 1
> + - #address-cells: should be 1
> + - #size-cells: should be 0
> +
> +Sub-nodes:
> +Each PHY should be represented as a sub-node.
> +
> +Sub-nodes
> +required properties:
> +- reg: the PHY number
> + "0" - PHY connect to OTG controller
> + "1" - PHY connect to HOST0 controller
> + "2" - PHY connect to HOST1 controller
> +
> +Optional Properties:
> +- clocks : phandle + clock specifier for the phy clocks
> +
> +Example:
> +
> +usbphy: phy {
> + #phy-cells = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "rockchip,rk3288-usb-phy";
> + rockchip,grf = <&grf>;
> +};

Could you reorder these properties to have the same order than in the
"required properties" ? Something like:

usbphy: phy {
compatible = "rockchip,rk3288-usb-phy";
rockchip,grf = <&grf>;
#phy-cells = <1>;
#address-cells = <1>;
#size-cells = <0>;
};

Thanks,
Romain


\
 
 \ /
  Last update: 2014-12-09 16:21    [W:0.158 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site