Messages in this thread | | | Subject | Re: [PATCH] input: edt-ft5x06: fixed a macro coding style issue | From | Joe Perches <> | Date | Mon, 08 Dec 2014 22:44:20 -0800 |
| |
On Tue, 2014-12-09 at 08:34 +0200, Asaf Vertz wrote: > Fixed a coding style error, macros with complex values should be > enclosed in parentheses. [] > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c [] > @@ -849,10 +849,11 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client, > return 0; > } > > -#define EDT_ATTR_CHECKSET(name, reg) \ > +#define EDT_ATTR_CHECKSET(name, reg) { \ > if (pdata->name >= edt_ft5x06_attr_##name.limit_low && \ > pdata->name <= edt_ft5x06_attr_##name.limit_high) \ > - edt_ft5x06_register_write(tsdata, reg, pdata->name) > + edt_ft5x06_register_write(tsdata, reg, pdata->name); \ > +}
Any time you see a naked if (foo) bar in a macro prefer to use a do while (0) like;
#define EDT_ATTR_CHECKSET(name, reg) \ do { \ if (pdata->name >= edt_ft5x06_attr_##name.limit_low && \ pdata->name <= edt_ft5x06_attr_##name.limit_high) \ edt_ft5x06_register_write(tsdata, reg, pdata->name); \ while (0)
| |