lkml.org 
[lkml]   [2014]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] USB: serial: add nt124 usb to serial driver
From
Thanks for the review.

I didn't update the MAINTAINERS file because I looked in it and didn't
see any other individual usb/serial drivers listed with maintainers.

-George

On Mon, Dec 8, 2014 at 6:29 PM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
> George,
>
> On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote:
>> This driver is for the NovaTech 124 4x serial expansion board for the
>> NovaTech OrionLXm.
>>
>> Firmware source code can be found here:
>> https://github.com/novatechweb/nt124
>>
>> Signed-off-by: George McCollister <george.mccollister@gmail.com>
>> ---
>> drivers/usb/serial/Kconfig | 9 +
>> drivers/usb/serial/Makefile | 1 +
>> drivers/usb/serial/nt124.c | 429 ++++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 439 insertions(+)
>> create mode 100644 drivers/usb/serial/nt124.c
>>
>> diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
> [...]
>
> It applies to next without any errors, there are no checkpatch issues
> other than recommending updating the MAINTAINERS file, and I can't find
> any other obvious problems. Looks good to me.
>
> Reviewed-by: Jeremiah Mahler <jmmahler@gmail.com>
>
> --
> - Jeremiah Mahler


\
 
 \ /
  Last update: 2014-12-09 02:01    [W:0.105 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site