lkml.org 
[lkml]   [2014]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string
    Am 08.12.2014 um 08:11 schrieb Julia Lawall:
    >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
    >>> index 35aef5e..0a9c41f 100644
    >>> --- a/drivers/mtd/nand/s3c2410.c
    >>> +++ b/drivers/mtd/nand/s3c2410.c
    >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev)
    >>>
    >>> cpu_type = platform_get_device_id(pdev)->driver_data;
    >>>
    >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev);
    >>> + pr_debug("%s(%p)\n", __func__, pdev);
    >>
    >> I think we can drop the line completely.
    >> We have ftrace to trace function calls...
    >
    > Should the "initialised ok" at the end of the function be remove as well?
    >
    > Will it be confusing if this cleanup is done in this function, but not in
    > others where it may be useful? Perhaps s3c2410_nand_update_chip, for
    > example?

    Hmm, this driver seems to have a lot of debugging printks().
    IMHO we can remove them.
    Let's see what Brain says.

    Thanks,
    //richard


    \
     
     \ /
      Last update: 2014-12-08 11:01    [W:4.326 / U:1.920 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site