Messages in this thread | | | Date | Sun, 7 Dec 2014 11:31:05 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] mm: memcontrol.c: Cleaning up function that are not used anywhere |
| |
On Sat 06-12-14 17:45:56, Rickard Strandqvist wrote: > Remove function mem_cgroup_lru_names_not_uptodate() that is not used anywhere. > And move BUILD_BUG_ON() to the beginning of memcg_stat_show() instead. > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Michal Hocko <mhocko@suse.cz>
> --- > mm/memcontrol.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d6ac0e3..5e2f0f3 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4379,17 +4379,14 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v) > } > #endif /* CONFIG_NUMA */ > > -static inline void mem_cgroup_lru_names_not_uptodate(void) > -{ > - BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS); > -} > - > static int memcg_stat_show(struct seq_file *m, void *v) > { > struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m)); > struct mem_cgroup *mi; > unsigned int i; > > + BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS); > + > for (i = 0; i < MEM_CGROUP_STAT_NSTATS; i++) { > if (i == MEM_CGROUP_STAT_SWAP && !do_swap_account) > continue; > -- > 1.7.10.4 >
-- Michal Hocko SUSE Labs
| |