Messages in this thread | | | Date | Wed, 3 Dec 2014 10:00:20 -0800 | From | Darren Hart <> | Subject | Re: [PATCH v3] platform: x86: dell-laptop: Add support for keyboard backlight |
| |
On Fri, Dec 05, 2014 at 12:53:31PM +0100, Pali Rohár wrote: > This patch adds support for configuring keyboard backlight settings on supported > Dell laptops. It exports kernel leds interface and uses Dell SMBIOS tokens or > keyboard class interface. > > With this patch it is possible to set: > * keyboard backlight level > * timeout after which will be backlight automatically turned off > * input activity triggers (keyboard, touchpad, mouse) which enable backlight > * ambient light settings > > Settings are exported via sysfs: > /sys/class/leds/dell::kbd_backlight/ > > Code is based on newly released documentation by Dell in libsmbios project. > > Thanks to Dan Carpenter who reported bug about unpredictable results in > quirks->kbd_timeouts for loop. His fix adds needs_kbd_timeouts flag to > quirk structure to indicate if kbd_timeouts array is empty or not. > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> > Cc: Dan Carpenter <dan.carpenter@oracle.com>
Applied to testing with minor English corrections to the new comments.
Thank you Pali.
-- Darren Hart Intel Open Source Technology Center
| |