lkml.org 
[lkml]   [2014]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.17 049/122] powerpc/powernv: Fix the hmi event version check.
    Date
    3.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>

    commit 6acbc5a1dab30aa8f7be7bf3852f343f89147ac5 upstream.

    The current HMI event structure is an ABI and carries a version field to
    accommodate future changes without affecting/rearranging current structure
    members that are valid for previous versions.

    The current version check "if (hmi_evt->version != OpalHMIEvt_V1)"
    doesn't accomodate the fact that the version number may change in
    future.

    If firmware starts returning an HMI event with version > 1, this check
    will fail and no HMI information will be printed on older kernels.

    This patch fixes this issue.

    Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
    [mpe: Reword changelog]
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/powerpc/platforms/powernv/opal-hmi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/powerpc/platforms/powernv/opal-hmi.c
    +++ b/arch/powerpc/platforms/powernv/opal-hmi.c
    @@ -57,7 +57,7 @@ static void print_hmi_event_info(struct
    };

    /* Print things out */
    - if (hmi_evt->version != OpalHMIEvt_V1) {
    + if (hmi_evt->version < OpalHMIEvt_V1) {
    pr_err("HMI Interrupt, Unknown event version %d !\n",
    hmi_evt->version);
    return;



    \
     
     \ /
      Last update: 2014-12-06 01:21    [W:4.024 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site