Messages in this thread | | | Subject | Re: [PATCH] staging: kernel: fixed style errors in pid.c | From | Joe Perches <> | Date | Thu, 04 Dec 2014 22:39:42 -0800 |
| |
On Fri, 2014-12-05 at 15:27 +0900, Joshua I. James wrote: > Fixed style errors identified by checkpatch.
Your subject is not correct.
This is not staging.
Please submit patches only for drivers/staging until until you are _very_ familiar with kernel style.
And most whitespace only changes to kernel/... are not particularly welcomed by the most experienced kernel developers.
> diff --git a/kernel/pid.c b/kernel/pid.c [] > @@ -471,8 +478,10 @@ EXPORT_SYMBOL_GPL(get_task_pid); > struct task_struct *get_pid_task(struct pid *pid, enum pid_type type) > { > struct task_struct *result; > + > rcu_read_lock(); > result = pid_task(pid, type); > +
Unnecessary blank line added here.
btw: using scripts/checkpatch.pl --fix-inplace --strict would have been better.
| |