Messages in this thread | | | Date | Fri, 5 Dec 2014 23:30:00 +0100 | Subject | Re: [PATCH 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller. | From | Rafał Miłecki <> |
| |
On 5 December 2014 at 20:35, Graham Moore <grmoore@opensource.altera.com> wrote: > + if (of_modalias_node(np, modalias, sizeof(modalias)) < 0) > + goto probe_failed; > + > + ret = spi_nor_scan(nor, modalias, SPI_NOR_QUAD); > + if (ret) > + goto probe_failed; > (...) > + > +static struct of_device_id cqspi_dt_ids[] = { > + {.compatible = "cdns,qspi-nor",}, > + { /* end of table */ } > +};
AFAIU of_modalias_node will give you "qspi-nor" string. Second argument passed to the spi_nor_scan is a chip name you expect on the device. Of course passing "qspi-nor" (if I'm right about of_modalias_node) doesn't make any sense.
Since my commit mtd: spi-nor: allow NULL as chip name and try to auto detect it second argument is optional.
Can you simply pass NULL instead of modalias?
-- Rafał
| |