lkml.org 
[lkml]   [2014]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/3] Dell Airplane Mode Switch driver
Date
On Friday 05 December 2014 21:53:10 Gabriele Mazzotta wrote:
> On Friday 05 December 2014 21:38:17 Pali Rohár wrote:
> > On Wednesday 03 December 2014 14:00:23 Darren Hart wrote:
> > > On Thu, Dec 04, 2014 at 10:55:32AM +0100, Pali Rohár wrote:
> > > > Darren, I think that if we do not solve problem with
> > > > duplicate key events (in dell-wireless.c) we should
> > > > postpone these patches to later kernel version. It is
> > > > better to not have such regression as it confuse
> > > > software like NetworkManager which is widely used.
> > >
> > > OK, that's what I needed. Thanks. Ignore my previous
> > > request, you answered it here. I will drop
> > > dell-wireless.c and look for a combined solution from you
> > > and Alex for the next release.
> > >
> > > Thanks,
> >
> > And according to discussion about Side effect of pressing
> > special keys at [1] [2] we should not report this wireless
> > key event (as input device) to userspace. And Alex's driver
> > is doing that.
> >
> > [1] -
> > http://www.spinics.net/lists/platform-driver-x86/msg05922.h
> > tml [2] -
> > http://www.spinics.net/lists/platform-driver-x86/msg05924.h
> > tml
>
> Alex's patch is for those laptop whose BIOS only sends a
> notification to DELLABCE when Fn keys are pressed. His patch
> simply translates these ACPI notifications to KEY_RFKILL
> keypresses.
>

Yes, and your last patch disables sending such KEY events to
userspace (in dell-wmi driver). BIOS already handle changes, so
key press should not be reported to userspace... [1] (from
previous email).

> Correct if I'm wrong, but shouldn't his patch have no effects
> on your laptop? If I'm not wrong, CRBT returns 2 on your
> laptop, so the input device is not even created. Am I missing
> something?
>
> Gabriele

Yes, it has no effect for my laptop.

--
Pali Rohár
pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-12-05 22:41    [W:0.146 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site