lkml.org 
[lkml]   [2014]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] ARM: DaVinci: Deletion of an unnecessary check before the function call "__clk_disable"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 3 Dec 2014 09:01:33 +0100

    The __clk_disable() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    arch/arm/mach-davinci/clock.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/arch/arm/mach-davinci/clock.c b/arch/arm/mach-davinci/clock.c
    index c70bb0a..8f2c2d8 100644
    --- a/arch/arm/mach-davinci/clock.c
    +++ b/arch/arm/mach-davinci/clock.c
    @@ -55,8 +55,7 @@ static void __clk_disable(struct clk *clk)
    else if (clk->clk_disable)
    clk->clk_disable(clk);
    }
    - if (clk->parent)
    - __clk_disable(clk->parent);
    + __clk_disable(clk->parent);
    }

    int davinci_clk_reset(struct clk *clk, bool reset)
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-03 09:41    [W:3.923 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site