lkml.org 
[lkml]   [2014]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] misc: cxl: sysfs.c: Remove unused function
From
Date
> Remove the function mmio_size_show() that is not used anywhere.

Did you compile check this patch?

drivers/misc/cxl/sysfs.c:291:74: error: ‘mmio_size_show’ undeclared here (not in a function)

It's used here:
static struct device_attribute afu_attrs[] = {
__ATTR_RO(mmio_size),

> This was partially found by using a static code analysis program called cppcheck.

Thanks for letting me know which tool to avoid :-)

Mikey


>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/misc/cxl/sysfs.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c
> index ce7ec06..0431ec3 100644
> --- a/drivers/misc/cxl/sysfs.c
> +++ b/drivers/misc/cxl/sysfs.c
> @@ -102,17 +102,6 @@ static struct device_attribute afu_master_attrs[] = {
>
> /********* AFU attributes **************************************************/
>
> -static ssize_t mmio_size_show(struct device *device,
> - struct device_attribute *attr,
> - char *buf)
> -{
> - struct cxl_afu *afu = to_cxl_afu(device);
> -
> - if (afu->pp_size)
> - return scnprintf(buf, PAGE_SIZE, "%llu\n", afu->pp_size);
> - return scnprintf(buf, PAGE_SIZE, "%llu\n", afu->adapter->ps_size);
> -}
> -
> static ssize_t reset_store_afu(struct device *device,
> struct device_attribute *attr,
> const char *buf, size_t count)



\
 
 \ /
  Last update: 2014-12-21 05:41    [W:0.054 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site