lkml.org 
[lkml]   [2014]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] media: platform: add VPFE capture driver support for AM437X
Hi Hans,

On Tue, Dec 2, 2014 at 7:32 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 12/01/2014 11:27 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>> On 12/01/2014 11:11 AM, Hans Verkuil wrote:
>>>> Hi all,
>>>>
>>>> Thanks for the patch, review comments are below.
>>>>
>>>> For the next version I would appreciate if someone can test this driver with
>>>> the latest v4l2-compliance from the v4l-utils git repo. If possible test streaming
>>>> as well (v4l2-compliance -s), ideally with both a sensor and a STD receiver input.
>>>> But that depends on the available hardware of course.
>>>>
>>>> I'd like to see the v4l2-compliance output. It's always good to have that on
>>>> record.
>>>>
>>>>
>>>> On 11/24/2014 02:10 AM, Lad, Prabhakar wrote:
>>>>> From: Benoit Parrot <bparrot@ti.com>
>>>>>
>>>>> This patch adds Video Processing Front End (VPFE) driver for
>>>>> AM437X family of devices
>>>>> Driver supports the following:
>>>>> - V4L2 API using MMAP buffer access based on videobuf2 api
>>>>> - Asynchronous sensor/decoder sub device registration
>>>>> - DT support
>>>>>
>>>>> Signed-off-by: Benoit Parrot <bparrot@ti.com>
>>>>> Signed-off-by: Darren Etheridge <detheridge@ti.com>
>>>>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>>>>> ---
>>>>> .../devicetree/bindings/media/ti-am437xx-vpfe.txt | 61 +
>>>>> MAINTAINERS | 9 +
>>>>> drivers/media/platform/Kconfig | 1 +
>>>>> drivers/media/platform/Makefile | 2 +
>>>>> drivers/media/platform/am437x/Kconfig | 10 +
>>>>> drivers/media/platform/am437x/Makefile | 2 +
>>>>> drivers/media/platform/am437x/vpfe.c | 2764 ++++++++++++++++++++
>>>>> drivers/media/platform/am437x/vpfe.h | 286 ++
>>>>> drivers/media/platform/am437x/vpfe_regs.h | 140 +
>>>>> include/uapi/linux/Kbuild | 1 +
>>>>> include/uapi/linux/am437x_vpfe.h | 122 +
>>>>> 11 files changed, 3398 insertions(+)
>>>
>>> Can the source names be improved? There are too many 'vpfe' sources.
>>> Perhaps prefix all with 'am437x-'?
>>>
>> I did think of it but, dropped it as anyway the source's are present
>> in am437x folder, again naming the files am437x-xxx.x didn't make
>> me feel good. If you still insists I'll do it.
>
> Yes, please do. If you look at most other drivers they all have a prefix.
>
> Another reason is that the media_build system expects unique names.
>
OK makes sense I'll prefix it with 'am437x-'. probably fixing all the review
comments i'll post a v2 end of the day.

Thanks,
--Prabhakar Lad


\
 
 \ /
  Last update: 2014-12-02 09:21    [W:0.039 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site