Messages in this thread | | | Date | Tue, 2 Dec 2014 13:46:15 -0500 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent |
| |
On Tue, Dec 02, 2014 at 03:41:22PM +0100, Joerg Roedel wrote: > On Mon, Dec 01, 2014 at 03:28:03PM -0500, Konrad Rzeszutek Wilk wrote: > > On Fri, Nov 28, 2014 at 12:29:07PM +0100, Joerg Roedel wrote: > > > From: Joerg Roedel <jroedel@suse.de> > > > > > > Print a warning when all allocation tries have been failed > > > and the function is about to return NULL. This prepares for > > > calling the function with __GFP_NOWARN to suppress > > > allocation failure warnings before all fall-backs have > > > failed. > > > > This can be quite noisy. Especially the dump-stack. > > Well, this is as noisy as the dump_stack()s from the page-allocator when > the first allocation try fails. The goal of the first two patches in
Right, on the first allocation. Subsequent allocations won't be so noisy in the page-allocator (I think?). While this will be noisy on subsequent ones.
> this series is to only print a warning (with stack-trace) when > alloc_coherent failed, and not when only an intermediate step failed > that has a fall-back anyway (and might thus be no real problem). > > > Joerg >
| |