lkml.org 
[lkml]   [2014]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] ALSA: echoaudio: Deletion of a check before release_and_free_resource()
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 2 Dec 2014 18:34:45 +0100

    The release_and_free_resource() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    sound/pci/echoaudio/echoaudio.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
    index 60e4003..21228ad 100644
    --- a/sound/pci/echoaudio/echoaudio.c
    +++ b/sound/pci/echoaudio/echoaudio.c
    @@ -1875,8 +1875,7 @@ static int snd_echo_free(struct echoaudio *chip)
    if (chip->dsp_registers)
    iounmap(chip->dsp_registers);

    - if (chip->iores)
    - release_and_free_resource(chip->iores);
    + release_and_free_resource(chip->iores);


    pci_disable_device(chip->pci);
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-02 19:01    [W:4.260 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site