Messages in this thread Patch in this message | | | Date | Tue, 02 Dec 2014 14:00:51 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] of-unittest: Deletion of an unnecessary check before the function call "of_node_put" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 2 Dec 2014 13:54:00 +0100
The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/of/unittest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index cc0c5ec..06ebe9d 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -486,8 +486,7 @@ static void __init of_selftest_changeset(void) /* Make sure node names are constructed correctly */ selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")), "'%s' not added\n", n21->full_name); - if (np) - of_node_put(np); + of_node_put(np); mutex_lock(&of_mutex); selftest(!of_changeset_revert(&chgset), "revert failed\n"); -- 2.1.3
| |