lkml.org 
[lkml]   [2014]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] perf: fix building warning on ARM 32.
    Hi Wang,

    On Tue, Dec 16, 2014 at 02:19:06PM +0800, Wang Nan wrote:
    > Commit 85c116a6c introduces asprintf() call and matches '%ld' to a u64
    > argument, which is incorrect on ARM:
    >
    > CC /home/wn/util/srcline.o
    > util/srcline.c: In function 'get_srcline':
    > util/srcline.c:297:6: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'u64' [-Werror=format]
    > cc1: all warnings being treated as errors
    > make[1]: *** [/home/wn/util/srcline.o] Error 1
    >
    > In addition, all users of get_srcline() use u64 addr, and libbfd
    > also use 64 bit bfd_vma as address. This patch also fix prototype
    > of get_srcline() and addr2line() to use u64 addr instead of
    > unsigned long.
    >
    > Signed-off-by: Wang Nan <wangnan0@huawei.com>

    Acked-by: Namhyung Kim <namhyung@kernel.org>

    Thanks,
    Namhyung



    \
     
     \ /
      Last update: 2014-12-18 06:42    [W:4.256 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site