Messages in this thread | | | Date | Wed, 17 Dec 2014 21:32:27 -0700 | From | David Ahern <> | Subject | Re: [PATCH] tools lib traceevent: Add support for IP address formats |
| |
On 12/17/14 9:26 PM, Namhyung Kim wrote: > > It'd be better if we do it like below.. > > char i = *ptr++; > > Why not passing ptr + 1 to print_ip_arg()? >
That parsing loop is a bit weird - and deep. And I only wanted to consume 'pi' and 'pI' with parse_ip_arg if and only if the next letters are '4', '6' and 'S'.
David
| |