Messages in this thread | | | Date | Wed, 17 Dec 2014 15:16:30 -0500 | From | Dave Jones <> | Subject | Re: frequent lockups in 3.18rc4 |
| |
On Wed, Dec 17, 2014 at 11:51:45AM -0800, Linus Torvalds wrote: > On Wed, Dec 17, 2014 at 10:57 AM, Dave Jones <davej@redhat.com> wrote: > > On Wed, Dec 17, 2014 at 01:22:41PM -0500, Dave Jones wrote: > > > > > I'm going to try your two patches on top of .18, with the same kernel > > > config, and see where that takes us. > > > Hopefully to happier places. > > > > Not so much. Died very quickly. > > Damn, damn, damn. That's because of a stupid typo on the patches. We > have these very similar variables ("flags" and "fault") that have very > similar fault information, but they are completely different. > > The "fault & FAULT_FLAG_USER" test is wrong, it should test "flags & > FAULT_FLAG_USER". Patch attached.
Yup, that seems to be the only obvious bug in those commits. It's survived for long with that change on top.
> The half-way good news is that this certainly confirms that trinity is > triggering the "page fault with fatal signal pending" special case.
Now let's see how long it runs for..
Dave
| |