Messages in this thread | | | From | Thomas Renninger <> | Subject | Re: [PATCH] cpupower: Correctly detect if running as root | Date | Wed, 17 Dec 2014 17:22:54 +0100 |
| |
On Sunday, December 14, 2014 10:29:24 PM Rafael J. Wysocki wrote: > On Sunday, December 14, 2014 01:36:52 PM Michal Privoznik wrote: > > Some operations, like frequency-set, need root privileges. However, > > the way that this is detected is not correct. The getuid() is called, > > while in fact geteuid() should be. This way we can allow > > distributions or users to set SETUID flags on the cpupower binary if > > they want to and let regular users change the cpu frequency governor. > > > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> > > An ACK from Thomas is needed. Patch is correct, Thanks!
Acked-by: Thomas Renninger <trenn@suse.de>
Thomas > > > --- > > > > tools/power/cpupower/utils/cpupower.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/power/cpupower/utils/cpupower.c > > b/tools/power/cpupower/utils/cpupower.c index 7cdcf88..9ea9143 100644 > > --- a/tools/power/cpupower/utils/cpupower.c > > +++ b/tools/power/cpupower/utils/cpupower.c > > @@ -199,7 +199,7 @@ int main(int argc, const char *argv[]) > > > > } > > > > get_cpu_info(0, &cpupower_cpu_info); > > > > - run_as_root = !getuid(); > > + run_as_root = !geteuid(); > > > > if (run_as_root) { > > > > ret = uname(&uts); > > if (!ret && !strcmp(uts.machine, "x86_64") &&
| |