Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/3] usb: host: f_usb20ho: add support for Fujitsu ehci/ohci USB 2.0 host controller | Date | Wed, 17 Dec 2014 16:44:29 +0100 |
| |
On Wednesday 17 December 2014 23:33:02 Sneeker. Yeh wrote: > > > >No need for playing games with child devices, just see how the other drivers do > >it. > > I am wondering if this is what you mentioned here? : > Hcd21: f_usb20ho { > compatible = "fujitsu,f_usb20ho"; > ... > Ehci { > compatible = "generic-ehci"; > reg = <>; > } > ohci { > compatible = "generic-ohci"; > reg = <>; > } > } > By doing that, I can just use of_platform_populate() to create platform device more gracefully, > than using platform_device_xxx() those have been done in of_platform_populate(). > And also, managing register offset is totally done via dts description, not in the code.
What I mean is leaving out the fujitsu,f_usb20ho node entirely, just put the two USB controllers on the bus directly and remove this driver.
Arnd
| |