Messages in this thread | | | Subject | Re: [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Fix for possible null pointer dereference | From | Joe Perches <> | Date | Mon, 15 Dec 2014 15:53:16 -0800 |
| |
On Mon, 2014-12-15 at 23:23 +0100, Rickard Strandqvist wrote: > Hi Joe
Hello Rickard
> No, it does not look like end can be NULL then. > Then remove the end != NULL instead? > ... > if (end != NULL && *end == '.') {
Up to you.
> However, I am hesitant to the tolower() I think double case is faster...?
I doubt code execution speed is paramount here. Maybe see if the object code size is smaller one way or the other.
| |