lkml.org 
[lkml]   [2014]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()
Andy,

On Mon, Dec 15, 2014 at 03:47:04PM +0000, Andy Whitcroft wrote:
> On Sun, Dec 14, 2014 at 11:59:19PM -0800, Jeremiah Mahler wrote:
[...]
>
> The calculation appears identical to my reading, the original form was:
>
> next_gpadl_handle = atomic_read(&vmbus_connection.next_gpadl_handle);
> atomic_inc(&vmbus_connection.next_gpadl_handle);
>
> or:
>
> y = x;
> x++;
>
> so y == x' (x before incrementing)
>
> the new code is:
>
> next_gpadl_handle = (atomic_inc_return(&vmbus_connection.next_gpadl_handle) - 1);
>
> or:
>
> y = ++x - 1;
>
> Also making y = x' (x before incrementing)
>
> -apw

Ah, you are right. The increment before/after messed me up.

Thanks for clearing that up for me :-)

--
- Jeremiah Mahler


\
 
 \ /
  Last update: 2014-12-15 20:21    [W:0.467 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site