Messages in this thread | | | From | Peter Feuerer <> | Subject | Re: [PATCH -next] platform/x86/acerhdf: still depends on THERMAL | Date | Mon, 15 Dec 2014 18:10:14 +0100 |
| |
Randy Dunlap writes:
> From: Randy Dunlap <rdunlap@infradead.org> > > acerhdf uses thermal interfaces so it should depend on THERMAL. > It also should not select a thermal driver without checking that > THERMAL is enabled. > > This fixes the following build errors when THERMAL=m and > ACERHDF=y. > > drivers/built-in.o: In function `acerhdf_set_mode': > acerhdf.c:(.text+0x3e02e1): undefined reference to `thermal_zone_device_update' > drivers/built-in.o: In function `acerhdf_unbind': > acerhdf.c:(.text+0x3e052d): undefined reference to `thermal_zone_unbind_cooling_device' > drivers/built-in.o: In function `acerhdf_bind': > acerhdf.c:(.text+0x3e0593): undefined reference to `thermal_zone_bind_cooling_device' > drivers/built-in.o: In function `acerhdf_init': > acerhdf.c:(.init.text+0x1c2f5): undefined reference to `thermal_cooling_device_register' > acerhdf.c:(.init.text+0x1c360): undefined reference to `thermal_zone_device_register' > drivers/built-in.o: In function `acerhdf_unregister_thermal': > acerhdf.c:(.text.unlikely+0x3c67): undefined reference to `thermal_cooling_device_unregister' > acerhdf.c:(.text.unlikely+0x3c91): undefined reference to `thermal_zone_device_unregister' > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Peter Feuerer <peter@piie.net> > Cc: Darren Hart <dvhart@infradead.org> > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20141215.orig/drivers/platform/x86/Kconfig > +++ linux-next-20141215/drivers/platform/x86/Kconfig > @@ -38,8 +38,8 @@ config ACER_WMI > > config ACERHDF > tristate "Acer Aspire One temperature and fan driver" > + depends on ACPI && THERMAL > select THERMAL_GOV_BANG_BANG > - depends on ACPI > ---help--- > This is a driver for Acer Aspire One netbooks. It allows to access > the temperature sensor and to control the fan.
Acked-by: Peter Feuerer <peter@piie.net>
Thanks.
--peter;
| |