Messages in this thread | | | Date | Mon, 15 Dec 2014 11:48:29 -0500 (EST) | Subject | Re: [PATCH] net: stmmac: sti: Fix uninitialized pointer dereference if !OF | From | David Miller <> |
| |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Mon, 15 Dec 2014 12:25:51 +0100
> If CONFIG_OF is not set: > > drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c: In function ‘sti_dwmac_parse_data’: > drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c:318: warning: ‘rs’ is used uninitialized in this function > > of_property_read_string() will return -ENOSYS in this case, and rs will > be an uninitialized pointer. > > While the fallback clock selection is already selected correctly in this > case, the string comparisons should be skipped too, else the system will > crash while dereferencing the uninitialized pointer. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied.
| |