lkml.org 
[lkml]   [2014]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v3 1/2] iio: document ti-dac8554 devicetree bindings
On Mon, Dec 15, 2014 at 11:39:56AM +0000, Nikolaus Schulz wrote:
> Signed-off-by: Nikolaus Schulz <nikolaus.schulz@avionic-design.de>
> ---
> .../devicetree/bindings/iio/dac/ti-dac8554.txt | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/ti-dac8554.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/ti-dac8554.txt b/Documentation/devicetree/bindings/iio/dac/ti-dac8554.txt
> new file mode 100644
> index 0000000..32e96859
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/ti-dac8554.txt
> @@ -0,0 +1,22 @@
> +TI DAC8554 Digital to Analog Converter
> +
> +This driver supports the SPI bus.
The binding need not refer to the driver, this sentence can go. It might
be worth adding "(SPI)" to the first line.

> +
> +Required properties:
> + - compatible: must be "ti,dac8554"
> + - vref-supply: the vref power supply
> + - ti,address: the additional 2-bit chip address
> +
> +For required properties on SPI, please consult
> +Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +
> + dac8554@0 {
> + compatible = "ti,dac8554";
> + reg = <0>;
> + spi-max-frequency = <50000000>;
> +
> + vref-supply = <&vdd_vref>;
> + ti,address = <0>;

What's this property used for?

> + };

Otherwise this looks sane to me.

Mark.


\
 
 \ /
  Last update: 2014-12-15 14:41    [W:0.067 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site