lkml.org 
[lkml]   [2014]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: goldfish: Fix minor coding style
On Sat, 13 Dec 2014 17:29:26 +0100
Loic Pefferkorn <loic@loicp.eu> wrote:

> Hello,
>
> The convention for checking for NULL pointers is !ptr and not ptr == NULL.
> This patch fixes such occurences in goldfish driver, it applies against next-20141212
>
>
> Signed-off-by: Loic Pefferkorn <loic@loicp.eu>

Pointless churn. It makes it less readable if anything, and it removes
the type safety as you are now checking against 0 not (void *)0

NAK

Alan


\
 
 \ /
  Last update: 2014-12-13 20:41    [W:0.059 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site