Messages in this thread | | | Date | Sat, 13 Dec 2014 19:07:05 +0000 | From | One Thousand Gnomes <> | Subject | Re: [PATCH] staging: goldfish: Fix minor coding style |
| |
On Sat, 13 Dec 2014 17:29:26 +0100 Loic Pefferkorn <loic@loicp.eu> wrote:
> Hello, > > The convention for checking for NULL pointers is !ptr and not ptr == NULL. > This patch fixes such occurences in goldfish driver, it applies against next-20141212 > > > Signed-off-by: Loic Pefferkorn <loic@loicp.eu>
Pointless churn. It makes it less readable if anything, and it removes the type safety as you are now checking against 0 not (void *)0
NAK
Alan
| |