lkml.org 
[lkml]   [2014]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] phy: phy-samsung-usb2: Don't use same name for driver name and global structure
From
On Wed, Nov 12, 2014 at 3:54 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Using the same driver name for platform driver and a globally defined,
> structure used throughout the file, looks a bit unpleasing.
> So changing the driver name from "samsung_usb2_phy_driver" to
> "samsung_usb2_phy"
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Cc: Kamil Debski <k.debski@samsung.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> ---

Although just a trivial change, does it look valid ?

> drivers/phy/phy-samsung-usb2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-samsung-usb2.c b/drivers/phy/phy-samsung-usb2.c
> index 908949d..2934fb7 100644
> --- a/drivers/phy/phy-samsung-usb2.c
> +++ b/drivers/phy/phy-samsung-usb2.c
> @@ -226,7 +226,7 @@ static int samsung_usb2_phy_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static struct platform_driver samsung_usb2_phy_driver = {
> +static struct platform_driver samsung_usb2_phy = {
> .probe = samsung_usb2_phy_probe,
> .driver = {
> .of_match_table = samsung_usb2_phy_of_match,
> @@ -234,7 +234,7 @@ static struct platform_driver samsung_usb2_phy_driver = {
> }
> };
>
> -module_platform_driver(samsung_usb2_phy_driver);
> +module_platform_driver(samsung_usb2_phy);
> MODULE_DESCRIPTION("Samsung S5P/EXYNOS SoC USB PHY driver");
> MODULE_AUTHOR("Kamil Debski <k.debski@samsung.com>");
> MODULE_LICENSE("GPL v2");
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India


\
 
 \ /
  Last update: 2014-12-11 08:01    [W:0.191 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site