lkml.org 
[lkml]   [2014]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY
    From
    Date
    On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote:
    > On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote:
    > > diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c
    []
    > > +/*
    > > + * The higher 16-bit of this register is used for write protection
    > > + * only if BIT(13 + 16) set to 1 the BIT(13) can be written.
    > > + */
    > > +#define SIDDQ_MSK BIT(13 + 16)

    huh?

    This #define looks _very_ odd.

    Is this supposed to be a single bit 29 or
    some range?




    \
     
     \ /
      Last update: 2014-12-11 07:41    [W:3.070 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site