Messages in this thread | | | Subject | Re: [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested | From | Yingjoe Chen <> | Date | Wed, 10 Dec 2014 17:19:26 +0800 |
| |
On Tue, 2014-12-09 at 16:58 +0000, Catalin Marinas wrote: <...> > You mix timer and counter terms here. Anyway, of we use physical timer, > you could argue that it makes sense to use the corresponding physical > counter (CNTPCT). However, on arm64 we only expose CNTVCT to user VDSO > and we want to use the same in the kernel. When booting at EL2, CNTVCT > == CNTPCT because we control CNTVOFF, that's unless we have some broken > firmware that does not restore CNTVOFF correctly. That's what we want > to spot early, hence the aim to always use the virtual counter (but not > the timer, use use the physical timer as it makes it easier for KVM). > > So the patch below, on top of linux-next, should solve the BUG():
Thanks for detail explanation and the patch. I tested it on my platform and it did solve the issue. So,
Tested-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
Joe.C
| |