lkml.org 
[lkml]   [2014]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/2] soc: samsung: add exynos chipid driver support
Hi Yadwinder,

On Thursday 04 December 2014 11:56 PM, Yadwinder Singh Brar wrote:
> Hi Pankaj,
>
>
> On Wed, Dec 3, 2014 at 1:47 PM, Pankaj Dubey <pankaj.dubey@samsung.com
> <mailto:pankaj.dubey@samsung.com>> wrote:
>
> Exynos SoCs have Chipid, for identification of product IDs
> and SoC revisions. This patch intendes to provide initialization
> code for all these functionalites, at the same time it provides some
> sysfs entries for accessing these information to userspace.
>
> This driver usese existing binding for exnos-chipid.
>
> [ ... ]
>
> +
> +static unsigned int soc_product_id;
> +static unsigned int soc_revision;
> +
> +int exynos_product_id(void)
> +{
> + return soc_product_id;
> +}
> +EXPORT_SYMBOL(exynos_product_id);
> +
> +int exynos_revision(void)
> +{
> + return soc_revision;
> +}
> +EXPORT_SYMBOL(exynos_revision);
> +
>
>
> How about exporting only a struct containing members : soc_revision,
> soc_product_id

OK, keeping in mind that chipid driver might be used from other drivers
as well (such as asv) other than from mach-exynos, we can do this.

> and may be some more like asv/fused_info and keeping these function as

Other members such as fused_info etc. can be added as and when required.
As of now there is no active user of all those.

> inlines ?
>
> +static const char *exynos_product_id_to_name(unsigned int product_id)
>
>
> __init ? hmm .. I think almost whole driver other than __ATTR funcs.
>

OK, I'll take care of this in next patch version.

> Otherwise it looks nice to me :)
>
> Best Regards,
> Yadwinder


Thanks for review.

Pankaj Dubey


\
 
 \ /
  Last update: 2014-12-11 04:41    [W:0.073 / U:5.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site