lkml.org 
[lkml]   [2014]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: lustre: Fix the warning messages about casting without __user macro
On Tue, Dec 09, 2014 at 10:56:12PM -0800, Shalin Mehta wrote:
> From: Shalin Mehta <shalinmehta85@gmail.com>
>
> This issue is showed up while compiling with sparse. The iov_base in struct iovec struct explicitly declares that the assigned value should be user space pointer with __user macro. Where as here, the __user macro isn't used while casting.

... and pointers are not user space ones at all. Which is to say, quit
messing with casts; it's not struct iovec. Proper fix is to replace
it here (and in almost all places throughout drivers/staging/lustre) with
struct kvec. And yes, such a patch had been sent. Still not applied,
AFAICS...


\
 
 \ /
  Last update: 2014-12-10 08:41    [W:0.329 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site