lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection
    On Mon, Dec 01, 2014 at 04:30:44PM +0100, SF Markus Elfring wrote:
    > > Meanwhile Markus's error labels are absolutely useless. They give no
    > > indication of what going to the label does.
    >
    > Which names would be better acceptable for you?

    You named it after the goto location but the label name should be based
    on the label location to say what the goto does. Something like
    "err_put_fsinfo", "err_put_fat", and "err_unload" or like that.

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2014-12-01 20:41    [W:2.221 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site