Messages in this thread | | | Date | Mon, 1 Dec 2014 11:15:17 -0800 | Subject | Re: [RFC v3] debug: prevent entering debug mode on errors | From | Colin Cross <> |
| |
On Thu, Nov 27, 2014 at 1:49 AM, Daniel Thompson <daniel.thompson@linaro.org> wrote: > On 26/11/14 17:45, Colin Cross wrote: >> The original patch was more useful as it allowed re-enabling break on >> panic on specific devices where you were trying to debug a >> reproducible issue. What about using a module_param similar to >> kgdbreboot, but setting the default based on CONFIG_PANIC_TIMEOUT to >> avoid extra configuration? > > This change was due to my review so perhaps I'd better answer this... > > panic_timeout is the value of the panic sysctl. In addition to the > normal sysctl tooling (which I don't think is available on most android > systems), its value can be set using panic=0 on the kernel command line > or via /proc/sys/kernel/panic at runtime. > > CONFIG_PANIC_TIMEOUT merely sets the default value of the sysctl. I > guess perhaps the patch description could be improved to make this clearer. > > Therefore, the only loss of function I expected versus the original is > that it would be hard to get as far as a reproducible panic if the > system also has a ton of reproducible oopses that we don't want to fix. > Is such a use-case important?
OK, works for me.
| |