lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] GPU-DRM-MSM: Deletion of unnecessary checks before two function calls
    On Tue, Nov 25, 2014 at 02:33:53PM +0100, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Tue, 25 Nov 2014 14:30:28 +0100
    >
    > The functions framebuffer_release() and vunmap() perform also input
    > parameter validation. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/gpu/drm/msm/msm_fbdev.c | 3 +--
    > drivers/gpu/drm/msm/msm_gem.c | 3 +--
    > 2 files changed, 2 insertions(+), 4 deletions(-)

    This needs the same fix for the subject prefix that I mentioned for your
    other patch, otherwise:

    Reviewed-by: Thierry Reding <treding@nvidia.com>

    Perhaps a good idea would be to send all of these patches with the
    subject prefix fixed up as a second version and threaded in a series.
    That makes it easier for people to pick them up (assuming Dave will take
    them directly).

    Thierry
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-12-01 17:41    [W:4.766 / U:0.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site