lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] DMA: Delete a check before free_percpu()
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 1 Dec 2014 06:06:57 +0100

    The free_percpu() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/dma/dmaengine.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
    index 24bfaf0..e057935 100644
    --- a/drivers/dma/dmaengine.c
    +++ b/drivers/dma/dmaengine.c
    @@ -330,8 +330,7 @@ static int __init dma_channel_table_init(void)
    if (err) {
    pr_err("initialization failure\n");
    for_each_dma_cap_mask(cap, dma_cap_mask_all)
    - if (channel_table[cap])
    - free_percpu(channel_table[cap]);
    + free_percpu(channel_table[cap]);
    }

    return err;
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-01 06:41    [W:4.026 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site