lkml.org 
[lkml]   [2014]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] arm64: amd-seattle: Fix dma-ranges property
    Date
    On Sunday 30 November 2014 21:46:39 suravee.suthikulpanit@amd.com wrote:
    > From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
    >
    > AMD Seattle should support 40-bit DMA.
    >
    > Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
    >

    The change looks good, but two things about the patch description:

    - You should be a little more verbose, especially after we had discussed
    this to some detail on IRC, explain why you use the specific values.

    - You should configure git-send-email to know your full email address
    including the name. Right now it gets sent from
    "suravee.suthikulpanit@amd.com" instead of "Suravee Suthikulpanit
    <Suravee.Suthikulpanit@amd.com>", and that causes the extra From
    line at the start of the mail, besides looking a bit strange.

    Thanks,

    Arnd


    \
     
     \ /
      Last update: 2014-12-01 15:01    [W:2.994 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site