Messages in this thread | | | Subject | Re: [PATCH] lib: mpi: Use "static inline" instead of "extern inline" in header file for __GNUC__ | From | Joe Perches <> | Date | Sun, 09 Nov 2014 01:11:01 -0800 |
| |
On Sun, 2014-11-09 at 16:58 +0800, Chen Gang wrote: > In header file, "extern inline" may cause multiple definition, so need > change it to "static inline". And also need be quoted by __GNUC__ for > they are as inline functions only for __GNUC__. [] > diff --git a/lib/mpi/mpi-inline.h b/lib/mpi/mpi-inline.h [] > @@ -30,7 +30,7 @@ > #define G10_MPI_INLINE_H > > #ifndef G10_MPI_INLINE_DECL > -#define G10_MPI_INLINE_DECL extern inline > +#define G10_MPI_INLINE_DECL static inline
Why not remove the #define and use static inline in the 4 places the #define is currently used?
| |