lkml.org 
[lkml]   [2014]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: Early test: hangs in mm/compact.c w. Linus's 12d7aacab56e9ef185c
Date
> >
> > I guess this one would mitigate against Vlastmil's migration scanner issue,
> > wouldn't it?
>
Nope, I wanted to see if free pages are low enough.

> Please no, that's a wrong fix. The purpose of compaction is to make the
> high-order watermark meet, not give up.
>
Yupe, have to spin.

--- a/mm/compaction.c Sun Nov 9 12:02:59 2014
+++ b/mm/compaction.c Mon Nov 10 11:12:07 2014
@@ -1074,6 +1074,8 @@ static int compact_finished(struct zone
watermark = low_wmark_pages(zone);
watermark += (1 << cc->order);

+ if (!zone_watermark_ok(zone, 0, watermark, 0, 0))
+ return COMPACT_SKIPPED;
if (!zone_watermark_ok(zone, cc->order, watermark, 0, 0))
return COMPACT_CONTINUE;

--



\
 
 \ /
  Last update: 2014-11-10 05:01    [W:0.044 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site