Messages in this thread | | | Subject | Re: [PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device | From | Michael Ellerman <> | Date | Mon, 10 Nov 2014 10:04:57 +1100 |
| |
On Wed, 2014-11-05 at 06:21 -0800, Guenter Roeck wrote: > On Wed, Nov 05, 2014 at 04:45:14PM +0530, Neelesh Gupta wrote: > > The current driver probe() function assumes the sensor device to be > > alwary present and gets executed every time if the driver is loaded, > > but the appropriate hardware could not be present. > > > > So, move the platform device creation as part of platform init code > > and use the 'id_table' to check if the device present or not. > > > > Signed-off-by: Neelesh Gupta <neelegup@linux.vnet.ibm.com> > > Looks good. We'll need an ack from one of the powerpc maintainers to proceed.
Looks OK to me.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
| |