lkml.org 
[lkml]   [2014]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] spi: add support for DLN-2 USB-SPI adapter
On Fri, Nov 07, 2014 at 02:45:13PM +0200, Laurentiu Palcu wrote:

> +static int dln2_spi_transfer_one_message(struct spi_master *master,
> + struct spi_message *msg)

It's a bit sad not to do transfer_one() but it's reasonable not to
because of the fun way /CS is being set.

> + ret = dln2_spi_get_speed_range(dln2,
> + &master->min_speed_hz,
> + &master->max_speed_hz);

Strange indentation here.

> +static int dln2_spi_remove(struct platform_device *pdev)
> +{
> + struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));
> + struct dln2_spi *dln2 = spi_master_get_devdata(master);
> +
> + if (dln2_spi_enable(dln2, false) < 0)
> + dev_err(&pdev->dev, "Failed to disable SPI module\n");
> +
> + spi_master_put(master);

You shouldn't need this _put(), it's defeating the purpose of having the
devm_ registration.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-11-08 12:01    [W:0.128 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site