Messages in this thread | | | Date | Fri, 7 Nov 2014 14:08:46 +0000 | From | David Vrabel <> | Subject | Re: [Xen-devel] [PATCH V2 2/5] xen: Delay m2p_override initialization |
| |
On 07/11/14 13:19, Juergen Gross wrote: > On 11/07/2014 02:04 PM, David Vrabel wrote: >> >> I suppose this is the "make some functions static" but it's an >> unreviewable mess. If you can't do this with some one line changes >> adding "static" and perhaps some forward declarations then please drop >> this bit. > > Do you really prefer forward declarations instead of pure code movement? > I can do as you request, but just want to make sure.
Normally I prefer not having forward declarations... How about a patch that does this and then a 2nd patch that does the pure code motion. Maybe that will produce a better diff?
You can also try the --patience option for git diff (etc.). This may produce more readable diffs.
David
| |